Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compatibility with monorepos and rspack #48

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Improve compatibility with monorepos and rspack #48

merged 3 commits into from
Oct 9, 2023

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Sep 15, 2023

Use compiler.webpack.ProvidePlugin instead of require webpack, this is also available way in webpack, and can compatible with rspack.

This also avoid require to wrong webpack in node_modules when using monorepo

@Richienb Richienb changed the title feat: compatible with rspack Fix importing issue Oct 9, 2023
@Richienb Richienb changed the title Fix importing issue Improve compatibility with monorepos and rspack Oct 9, 2023
@Richienb Richienb merged commit 3474abf into Richienb:main Oct 9, 2023
0 of 3 checks passed
@ahabhgk ahabhgk deleted the feat-compat-rspack branch October 9, 2023 08:37
@hardfist
Copy link

hardfist commented Dec 4, 2023

@Richienb can you help do a release so we can remove our fork for rspack compatibility

@Richienb
Copy link
Owner

Richienb commented Dec 6, 2023

@Richienb can you help do a release so we can remove our fork for rspack compatibility

v3 real

@hardfist
Copy link

hardfist commented Dec 7, 2023

thanks

@slorber slorber mentioned this pull request Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Richienb Richienb Richienb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahabhgk @hardfist @Richienb